Fix issues regarding JAVA_HOME setup

[swanhtet1992]

This is well known issue (#4). Setting up JAVA7_HOME and JAVA8_HOME to work with Android Studio is really troublesome on OSX. I tried all the possible solutions and this is by far the best solution that worked on every machines and OS. I got the solution from this blog.

You just need to add the JAVA_HOME in gradle.properties file.

I hope this help.

Cheers,
SH

[Naitbit]

This will break Windows, Linux, Travis and CircleCi builds.

[swanhtet1992]

@Naitbit, I think if gradle.properties is ignored by git and make it mandatory work for setup, it won't break.
Just have to create gradle.properties file with the path to jdk.

[Naitbit]

It will also break Mac builds if someone have different java7 or java 8 version.
I cannot merge this, but you can use it as an example how to hardcode those variables on your local machine.

[Naitbit]

local.properties is ignored by git.

[swanhtet1992]

Sorry for bothering but I still believe this option should provide. I made some changes like this below. Please take a look. I think this won't break for other machines.

It is not local.properties. It is inside gradle.properties.

[swanhtet1992]

Should I made changes and send PR again to test CI build?

[Naitbit]

You can make changes, so java7/java8 path can be set from properties file (as alternative to env variable), but I suggest to not hardcode specific version in commited file(unless it is in comment only form). You can also update readme with this information.

Dnia 4 marca 2016 11:51:45 CET, Swan Htet Aung notifications@github.com napisał(a):

Should I made changes and send PR again?

---

Reply to this email directly or view it on GitHub:
#7 (comment)

Sebastian Kacprzak

[swanhtet1992]

@Naitbit Is this O.K now?

[Naitbit]

Sorry I did not have time to look at it yet. I'll try to check it soon.

[Naitbit]

@swanhtet1992 Please check feature/retrolambda_config branch (that contains your changes) and check if it works for you
https://github.com/byoutline/kickmaterial/tree/feature/retrolambda_config

[swanhtet1992]

@Naitbit it works! 🤓And that refactoring part is awesome!!! 👏

[Naitbit]

Good to hear. Thanks for implementing initial version. I'll merge it.