Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve globs using pathlib.glob() #37

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

AdrianDsg
Copy link
Contributor

fix #35

I just managed to integrate support for globs as mentioned in #35.

There might be more efficient ways to integrate this feature. Please feel free to share your feeback below.

@AdrianDsg
Copy link
Contributor Author

AdrianDsg commented Jan 25, 2024

I'd be very grateful if @byrnereese would consider sharing a short feedback on this.

@byrnereese
Copy link
Owner

@AdrianDsg Thank you for the contribution. Do me one small favor - add something in the README.md about support for globs!

@byrnereese
Copy link
Owner

It also appears the unit tests are failing. I am not sure if this change caused this error, but could you take a look? I think we just need to update the HASH value in the assertion:

Update:
544b92316ee6219418120cfc0347f6f1b996f93833287777345da06a38f5f05e374d87a1a35e6bee96508169262d8f97
Change to:
468e45e1d823325ceebfd1c3eaa6e390c9629b43eaefcbdf5ff5d3c77cb358e10737d19d44ab0ad17f66a9935800c135

Update:
c102275d47fb49aeda0c2e35c35daf5da1ef5ce96f5360cf329578dc65e70b53249b20017b77bcc2516f672917d75762
Change to:
b164f41214bc362faf6a43c57be6c783a276ae188450b9f91ba27d4ffd581426e7e7902c9ce1dc93279f4b0badb92ec1

@AdrianDsg
Copy link
Contributor Author

AdrianDsg commented Jan 26, 2024

It also appears the unit tests are failing. I am not sure if this change caused this error, but could you take a look? I think we just need to update the HASH value in the assertion [...]

@byrnereese you were mostly right about the reason for the failing tests. The file hashes needed to be replaced but I also had to fix a bug that I previously introduced when using pathlib to resolve globs.

@byrnereese byrnereese merged commit d685161 into byrnereese:master Jan 29, 2024
4 checks passed
@byrnereese
Copy link
Owner

Released as 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for glob syntax in {css,js}_files lists
2 participants