Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive Usage Bar Granularity #23

Closed
CosmicHorrorDev opened this issue Jul 12, 2019 · 3 comments
Closed

Interactive Usage Bar Granularity #23

CosmicHorrorDev opened this issue Jul 12, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@CosmicHorrorDev
Copy link
Contributor

I think it would be nice to have the usage bar from interactive mode support the different eighths sections instead of just full or empty. I already have a hacky version that adds this functionality.

@vks
Copy link
Contributor

vks commented Jul 25, 2019

It probably makes sense to use https://github.com/mitsuhiko/indicatif in the long term for this and progress reporting.

@ghost ghost added help wanted Extra attention is needed enhancement New feature or request labels Jul 26, 2019
@ghost
Copy link

ghost commented Jul 26, 2019

indicatif would also be my choice, but it would certainly be interesting to get a look at the version that @LovecraftianHorror created to get a better idea of what they mean.

Just some notes about the current implementation.

  • when scanning the disk, there is a rate-limited update every few milliseconds, but due to the way it works the actual entry (the one with the percentage and bar) updates much more rarely. Numbers take time to bubble up.
  • When deleting entries, it will only send an update after each entry in the list was deleted. If big folders are deleted, there is no much to see for a while. This is something that could certainly benefit a lot from enhancements.

@CosmicHorrorDev
Copy link
Contributor Author

82333ac and 26b9569 add this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants