Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] A new version that target Rails 4.2+ #32

Closed
wants to merge 3 commits into from

Conversation

yesmeck
Copy link

@yesmeck yesmeck commented May 19, 2015

  • Remove all compatibility code
  • Use new ActiveRecord API

@yesmeck
Copy link
Author

yesmeck commented May 19, 2015

Hi @byroot , I create this WIP PR early so that you can review my code, give me some advice (if you have any time).

@byroot
Copy link
Owner

byroot commented May 19, 2015

Sure. Please ping me back when you have a prototype.

@yesmeck
Copy link
Author

yesmeck commented May 19, 2015

@byroot Do you have any thoughts about the new version that I can add them to the checklist?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.51%) to 97.86% when pulling a9e08dc on yesmeck:rails-4.2 into 062b430 on byroot:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.51%) to 97.86% when pulling a9e08dc on yesmeck:rails-4.2 into 062b430 on byroot:master.

@byroot
Copy link
Owner

byroot commented May 19, 2015

Not really. But I would recommend to start fresh by totally removing the extension.rb file. And of course to take a good look at how store is now implemented in Rails.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.51%) to 97.86% when pulling a9e08dc on yesmeck:rails-4.2 into 062b430 on byroot:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.78%) to 96.59% when pulling e607316 on yesmeck:rails-4.2 into 062b430 on byroot:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.78%) to 96.59% when pulling e607316 on yesmeck:rails-4.2 into 062b430 on byroot:master.

@byroot byroot force-pushed the master branch 2 times, most recently from 0f4bbdc to f85e346 Compare February 11, 2016 14:55
@yesmeck yesmeck closed this Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants