Implemented opt-out feature for postgres json serialization #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,11 @@ module ClassMethods | |||
| def typed_store(store_attribute, options={}, &block) | |||
| dsl = DSL.new(options.fetch(:accessors, true), &block) | |||
|
|
|||
| serialize store_attribute, create_coder(store_attribute, dsl.columns).new(options[:coder]) | |||
| unless options[:no_coder] | |||
There was a problem hiding this comment.
I think coder: false would be better.
|
Also could you update the tests please? |
|
I couldn't get the tests running yesterday (sqlite3 gem is not working correctly). So I made a good guess... |
byroot
force-pushed
the
master
branch
2 times, most recently
from
0f4bbdc
to
f85e346
Compare
|
Master build was broken indeed :/ Sorry for that. I rebased you branch on top of a fixed master: https://travis-ci.org/byroot/activerecord-typedstore/builds/108555062 Let's see. |
|
Ok, build is green, merged as ee3065f Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to define dumb coder in each project that is using activerecord-typedstore .