Fix typed store on most recent ActiveRecord #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We were previously overriding `query_attribute` but that doesn't work anymore because of the alias added in rails/rails@7834363#diff-ce3d2308407d3b07185a0e86261c54e7R34
- Main motivation for this change was that this method got removed in rails/rails@d784043 . The change was later on reverted in rails/rails@75c309c (though the method signature isn't the same) Anyway, that made me realise that we shouldn't use `decorate_attribute_type` anymore but just `attribute` which is public API. Worth to note that we can only use `attribute` for application using Active Record 6.1 because a feature was added to `attribute` which makes it accept blockes (that we need for the subtype of a column after the schema is loaded) rails/rails@2d98240#diff-1fdaa87a21737c884c4415e2c392e418R208
|
Seems like the rails-master Gemfile need to specify a newer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is two commits that fix two distinct issues.
cc/ @casperisfine