-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File encoding guessing with charade (= chardet) #21
Comments
For now I stated that guessing the encoding belongs to the application that use pysrt. But now that you talk about it, it's silly because we already detect encoding through BOMs in the library and we also depends of chardet because of the srt command. So I think it's a good idea. If you want to fill a pull request tell me, otherwise I'll do it in a few days. Le 2012-12-08 à 14:31, Antoine Bertin notifications@github.com a écrit :
|
I can't figure out why but the python3 version of It return me different variations of ISO encodings for my tests files. I should fill an issue ... For now it delay the |
Everything is green now. |
This could be used on a failed attempt to open a file due to UnicodeDecodeError. charade would be called to detect the encoding and a second attempt to open the file would be done.
This would be the default behavior and suppressed if encoding argument
is not None
.What do you think?
The text was updated successfully, but these errors were encountered: