Feature/prs cs hmcmc #509
Merged
Feature/prs cs hmcmc #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akotlar
reviewed
Jun 10, 2024
| from pyro.distributions import Gamma, Normal # type: ignore | ||
|
|
||
|
|
||
| class BasePrsCS: |
There was a problem hiding this comment.
Could we add a quick docstring here?
akotlar
reviewed
Jun 10, 2024
| might override these but these are common/basic enough to leave in | ||
| as an implemented method. | ||
|
|
||
| Parameters |
There was a problem hiding this comment.
coudl we add the parameters and returns?
akotlar
reviewed
Jun 10, 2024
|
|
||
|
|
||
| class PrsCSData(BasePrsCS): | ||
| def fit(self, Z, y): |
There was a problem hiding this comment.
again just a quick docstring here, if amenable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.