Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][annotation, proteomics] Refine annotation api interface, proteomic api join interface, add ability to join somascan data #514

Conversation

akotlar
Copy link
Collaborator

@akotlar akotlar commented May 27, 2024

  • Refines annotation dataset: melt_by_field => explode_field, melt_by_samples => melt_samples, and improve docstring explanations for both. These names more accurately describe what these arguments do
  • Refine proteomic join interface, and TandemMassTagDataset: TandemMassTagDataset class is now a msgspec.Struct, and we do not force drop fields. We also now do not force rename fields, besides Index => gene_name; this may be restored in the future as we support additional variations of Frappe datasets
  • Enable ability to join on either gene_name or ProteinID columns.
  • Improve the example proteomic notebook to better demonstrate melting_samples and explode_field

WIP because we still need to add the function to join on somascan data, and expand tests.

akotlar and others added 28 commits May 23, 2024 21:43
…imary_keys field, and warn when melt_by_field is not in primary_keys
…tein id columns; rename melt_by_samples to melt_samples, and melt_by_field to explode_field, and more accurately describe what the settings do
Co-authored-by: cristinaetrv <24943967+cristinaetrv@users.noreply.github.com>
…com:akotlar/bystro into feature/issue_421_opensearch_api_v2_backup2
@akotlar
Copy link
Collaborator Author

akotlar commented May 28, 2024

closing in favor of #515

With Github's implementation of squash merge, rebasing is too complex

@akotlar akotlar closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant