This repository has been archived by the owner on Dec 6, 2023. It is now read-only.
Improved cmedb export function #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem ! let me know when you are ready :) cc @maaaaz |
|
At the moment, I can't find mssql export function. So I will just start with the most commonly used SMB export section. |
|
I hope that I did a fix conflict correctly. I've not had to do that before... My apologies. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to make another PR so soon after the last one regarding roughly the same function.
In this PR, I've made a function
write_csvthat would simplify creating the CSV files. Using the CSV writer module to make sure other exports are also clean.I've rewritten a bunch of the export features to follow the same calling convention of
export <shares/creds/hosts/local_admins> <simple/detailed> <filename>.Unfortunately, that does mean the export creds will now export both plaintext and hashes and will be up the user to filter out.
Finally, I also added
local_adminsto the export type to display what users have admin on what machines.At the moment, I only have touched the SMB side of things, just wanted to get input before I continue onwards.