GenerateDimLabelDifference: Don't ignore case #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
force-pushed
the
bugfix/dimlabel-difference-case-sensitive
branch
from
9c5dadc
to
76d1261
Compare
|
Please have a look. |
MichaelHuth
previously approved these changes
Mar 28, 2023
We use EqualWaves for comparison of dimension labels and that does it since forever case sensitive. So we have to also output a difference if the labels only differ in case. Bug introduced in the initial version in 493779d (EQUAL_WAVE_WRAPPER: Work around EqualWaves dimension labels bug, 2019-03-12).
t-b
force-pushed
the
bugfix/dimlabel-difference-case-sensitive
branch
from
76d1261
to
9ee6214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use EqualWaves for comparison of dimension labels and that does it since forever case sensitive.
So we have to also output a difference if the labels only differ in case. Bug introduced in the initial version in 493779d (EQUAL_WAVE_WRAPPER: Work around EqualWaves dimension labels bug, 2019-03-12).