Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(advisor): limit value list len in PostgreSQL INSERT statement #2929

Merged
merged 2 commits into from Oct 9, 2022
Merged

feat(advisor): limit value list len in PostgreSQL INSERT statement #2929

merged 2 commits into from Oct 9, 2022

Conversation

zeroslope
Copy link
Contributor

@cla-bot
Copy link

cla-bot bot commented Oct 8, 2022

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please please sign CLA and add your name to contributors list.

d-bytebase
d-bytebase reviewed Oct 8, 2022
View reviewed changes
Copy link
Contributor

@d-bytebase d-bytebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @rebelice may want to take a look too.

@d-bytebase
Copy link
Contributor

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please please sign CLA and add your name to contributors list.

Thanks for your contribution. You may follow a change similar to bytebase/clabot-config#28. Thanks!

rebelice
rebelice requested changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@rebelice rebelice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, otherwise

plugin/advisor/pg/advisor_insert_row_limit.go Outdated Show resolved Hide resolved
@cla-bot
Copy link

cla-bot bot commented Oct 9, 2022

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please please sign CLA and add your name to contributors list.

zeroslope added a commit to zeroslope/clabot-config that referenced this pull request Oct 9, 2022
@zeroslope
Update .clabot
4d51e87 
bytebase/bytebase#2929
@zeroslope zeroslope mentioned this pull request Oct 9, 2022
Merged
@d-bytebase
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 9, 2022
@cla-bot
Copy link

cla-bot bot commented Oct 9, 2022

The GitHub CLA Bot is rechecking to see that you have signed the CLA

@rebelice rebelice enabled auto-merge (squash) October 9, 2022 05:46
@rebelice rebelice merged commit 9654541 into bytebase:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@d-bytebase d-bytebase d-bytebase approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zeroslope @d-bytebase @rebelice