Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bytebase helm chart #7481

Merged
merged 4 commits into from Aug 11, 2023
Merged

fix: fix bytebase helm chart #7481

merged 4 commits into from Aug 11, 2023

Conversation

1aal
Copy link
Contributor

@1aal 1aal commented Aug 10, 2023 •
edited

The following suggestions:

  1. The default DSN value of external pg in values.yaml is: postgresql://user:secret@host:port/dbname, it is not available. It's better to provide an explanation in the document rather than offering an unavailable default value.
  2. The service 'bytebase-entrypoint' lacks a selector label. So i unify label flied in the _helpers.tpl

@1aal 1aal requested review from d-bytebase and a team as code owners August 10, 2023 03:05
@cla-bot cla-bot bot added the cla-signed label Aug 10, 2023
@d-bytebase d-bytebase requested a review from h3n4l August 10, 2023 03:18
h3n4l
h3n4l requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@h3n4l h3n4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, using scripts/package_helm.sh to generate a new version when review completed.

helm-charts/bytebase/values.yaml Outdated Show resolved Hide resolved
@d-bytebase
Copy link
Contributor

@h3n4l
Copy link
Member

h3n4l commented Aug 11, 2023

Thanks @1aal !

h3n4l
h3n4l approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@h3n4l h3n4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-bytebase
Copy link
Contributor

Thanks for the change!

@h3n4l h3n4l merged commit fa4915f into bytebase:main Aug 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3n4l h3n4l h3n4l approved these changes

@d-bytebase d-bytebase Awaiting requested review from d-bytebase d-bytebase is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1aal @d-bytebase @h3n4l