fix: update bytebase-sql-review.yml for CICD #8984
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tthe `echo` command is wrapped in double quotes to preserve the JSON structure stored in the `content` variable. in some case, it'll return ``` sh: 0: unknown operand ``` and cause script run incorrectly
Tthe `echo` command is wrapped in double quotes to preserve the JSON structure stored in the `content` variable. in some case, it'll return ``` sh: 0: unknown operand ``` and cause script run incorrectly
Update bytebase-sql-review.yml
bds-congnguyen
requested review from
d-bytebase,
ecmadao and
a team
as code owners
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please please sign CLA and add your name to contributors list. |
RainbowDashy
approved these changes
Oct 30, 2023
|
LGTM, please sign the cla. |
|
@cla-bot check. |
|
The GitHub CLA Bot is rechecking to see that you have signed the CLA |
d-bytebase
changed the title
d-bytebase
changed the title
already signed CLA, can you help me recheck CLA? |
|
Thanks! |
d-bytebase
pushed a commit
that referenced
this pull request
Oct 30, 2023
|
The change has been cherry-picked to 2.10.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Sometimes, the pipeline return sql review passed but when deploy on Bytebase, the sql checking (UI) return some warning/error check.
We re-review log in cicd and noticed that script return
that cause next steps in script will always failed because there is no data.
Fix:
The
echocommand is wrapped indouble quotesto preserve the JSON structure stored in thecontentvariable.in some case, it'll return
and cause script run incorrectly