Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prometheus): add a field in config file to specify listen socket address #592

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

h3nill
Copy link

@h3nill h3nill commented Mar 17, 2023

Description

  • When port is specified listen is ignored.
  • When both are not specific default socket address used is 127.0.0.1:9042
  • port is deprecated and will be removed in future breaking release.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md.

@mnpw
Copy link
Member

mnpw commented Mar 21, 2023

LGTM

@h3nill h3nill merged commit c3f82f5 into main Mar 21, 2023
@h3nill h3nill deleted the prometheus-addr branch March 21, 2023 06:03
carlocorradini pushed a commit to carlocorradini/rumqtt that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants