Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder pattern for constructing Link #659

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Builder pattern for constructing Link #659

merged 4 commits into from
Jul 21, 2023

Conversation

swanandx
Copy link
Member

@swanandx swanandx commented Jul 11, 2023

Support for constructing LinkRx/LinkTx using LinkBuidler.

let (link_tx, link_rx, notification) = LinkBuilder::new(&client_id, router_tx)
    .tenant_id(tenant_id) // None by default
    .clean_session(clean_session) // true by default
    .last_will(lastwill) // None by default
    .dynamic_filters(dynamic_filters) // false by default
    .topic_alias_max(topic_alias_max) // 0 by default
    .build()?;

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if its relevant of user of the library. If its not relevant mention why.

Copy link
Member

@mnpw mnpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks 🚀🚀🚀

please merge after addressing the comments

rumqttd/src/link/local.rs Show resolved Hide resolved
rumqttd/src/link/local.rs Show resolved Hide resolved
@swanandx swanandx merged commit cea0d8b into main Jul 21, 2023
3 checks passed
@swanandx swanandx deleted the link-builder branch July 21, 2023 11:15
carlocorradini pushed a commit to carlocorradini/rumqtt that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants