Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console configuration should be optional #737

Merged
merged 2 commits into from
Oct 23, 2023
Merged

console configuration should be optional #737

merged 2 commits into from
Oct 23, 2023

Conversation

swanandx
Copy link
Member

Fixes #672 .

Changes:

  • make console settings optional
  • instead of blocking on console in start(), we block on joining thread handle of spawned servers.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@swanandx swanandx merged commit c2c576d into main Oct 23, 2023
3 checks passed
@swanandx swanandx deleted the optional-console branch October 23, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3nill h3nill h3nill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rumqttd | make console config optional
2 participants
@swanandx @h3nill