Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rust-cache with proper key and global RUSTFLAG #764

Merged
merged 14 commits into from
Dec 8, 2023
Merged

Conversation

swanandx
Copy link
Member

@swanandx swanandx commented Dec 7, 2023

CI isn't caching properly. let's say a PR is opened, job runs and saves cache with key "-c4efedb3", now if I push a commit ( editing changelog ), it has restore key of "-fda4c98d.." so it never finds the cache which it should have!

Basically, we are never seeing an cache hit.

This solves two things:

  • use keys with runner.os ( for cache hits )
  • set `RUSTFLAG: -D warnings" globally instead of just clippy ( otherwise the cache is invalidated and project is rebuilt every time! )

Type of change

  • Miscellaneous (related to maintenance)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@swanandx swanandx changed the title use github actions cache instead of rust-cache with proper key fix rust-cache with proper key and global RUSTFLAG Dec 7, 2023
@swanandx swanandx merged commit 99b2142 into main Dec 8, 2023
@swanandx swanandx deleted the workflow-cache-fix branch December 8, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants