Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MQTT v5 connection session_expiry_interval support #854

Merged
merged 5 commits into from May 16, 2024

Conversation

xiaocq2001
Copy link
Contributor

@xiaocq2001 xiaocq2001 commented Apr 30, 2024

Fixing issue #853

Type of change

New feature (non-breaking change which adds functionality)

  • Added session_expiry_interval support for MQTT V5 connection,

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! can you please also mention the changes in CHANGELOG as well?

rumqttc/examples/async_manual_acks_v5.rs Show resolved Hide resolved
@xiaocq2001
Copy link
Contributor Author

Thanks for the PR! can you please also mention the changes in CHANGELOG as well?

Updated.

rumqttc/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Devdutt Shenoi <devdutt@outlook.in>
@de-sh de-sh changed the title Add MQTT v5 connection session_expiry_interval support feat: add MQTT v5 connection session_expiry_interval support May 14, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9072384592

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • 107 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 36.497%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rumqttc/src/v5/mod.rs 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
rumqttd/src/segments/mod.rs 7 97.34%
rumqttc/src/state.rs 42 78.83%
rumqttc/src/v5/state.rs 58 67.56%
Totals Coverage Status
Change from base Build 8762117251: 0.1%
Covered Lines: 5983
Relevant Lines: 16393

💛 - Coveralls

@xiaocq2001
Copy link
Contributor Author

Moved the code to apply broker returned session_expiry_interval here, please check.

@de-sh de-sh requested a review from swanandx May 16, 2024 13:14
Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for your contribution!

@swanandx swanandx merged commit ce8422b into bytebeamio:main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants