New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MQTT v5 connection session_expiry_interval
support
#854
feat: add MQTT v5 connection session_expiry_interval
support
#854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! can you please also mention the changes in CHANGELOG as well?
Updated. |
Co-authored-by: Devdutt Shenoi <devdutt@outlook.in>
session_expiry_interval
support
Pull Request Test Coverage Report for Build 9072384592Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Moved the code to apply broker returned session_expiry_interval here, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for your contribution!
Fixing issue #853
Type of change
New feature (non-breaking change which adds functionality)
session_expiry_interval
support for MQTT V5 connection,Checklist:
cargo fmt
CHANGELOG.md
if it's relevant to the users of the library. If it's not relevant mention why.