Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow reloading tracing filter over http #136

Merged
merged 10 commits into from
Feb 21, 2023
Merged

feat: allow reloading tracing filter over http #136

merged 10 commits into from
Feb 21, 2023

Conversation

de-sh
Copy link
Member

@de-sh de-sh commented Feb 1, 2023

Closes #

Changes

Why?

Trials Performed

Locally, with CURL:

curl -X POST -H "Content-Type: text/plain" -d "uplink=debug,rumqtt=debug" http://localhost:3333

Problems noted during testing:

  • When uplink is started with the argument -vv for log level DEBUG and we try to increase to the TRACE level with the reload http request for the same, logs falter and don't work as expected.

@de-sh de-sh requested a review from tekjar February 1, 2023 11:11
@tekjar tekjar merged commit e15be6e into next Feb 21, 2023
@tekjar tekjar deleted the log-tracing branch February 21, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants