feat: load saved inflight publishes on uplink restart #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
changed the title
|
@Vilayat-Ali here are my suggestions:
|
Vilayat-Ali
force-pushed
the
vilayat/inflight-persistence
branch
from
d3a9674
to
dc7b77a
Compare
de-sh
added a commit
that referenced
this pull request
Dec 1, 2023
* Implemeted reading from disk and publishing onto the network * inflight persistence logic * doc: make the code readable --------- Co-authored-by: Devdutt Shenoi <devdutt@bytebeam.io>
de-sh
added a commit
that referenced
this pull request
Jan 4, 2024
* changes by vilayat * changes by vilayat * fix: basic implementation fixes, needs debugging * doc: note on where to load inflight publishes * fix: `EventLoop::clean` to force persist inflight * chore: cleanup * doc: remove outdated comments * doc: don't disconnect, note why * chore: rm unused loc * feat: load saved inflight publishes on uplink restart (#307) * Implemeted reading from disk and publishing onto the network * inflight persistence logic * doc: make the code readable --------- Co-authored-by: Devdutt Shenoi <devdutt@bytebeam.io> * chore: revert unrelated changes * doc: make it clear what is happening * doc: replace commented out code with TODO * fix: `Error=PacketIdZero` * chore: cargo update * fix: handle incoming data during inflight recovery * doc: describe undesired behavior * refactor: DRY `PersistenceFile` * log: add condition for successful completion * doc: improve comments in `recovery` * refactor: improve readability with placement * fix: merge breaking code * doc: code improvement TODO based on #311 * feat: `Ctrl` handles for `Mqtt` * refactor: remove code that never gets hit * refactor: load pending packets into eventloop * fix: delete file once read * refactor: error handling in recovery * fix: glienicke bridge to limit inflight growth * refactor: unnecessary copy * style: don't log before success * log: make sense * fix: save pending files from getting lost * fix: `VecDeque` to maintain order * doc: revert update to illustration * style: remove whitespace * rm: unused directories * chore: use main rumqtt * doc: update note * fix: don't change pkid of inflight * log: improve messaging * style: make it obvious --------- Co-authored-by: vilayat-ali <vilayatcodemysite@gmail.com> Co-authored-by: Syed Vilayat Ali Rizvi <73014428+Vilayat-Ali@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes
Added
reload_inflightmethod to the serializer module which reads from disk and publishes packets back ontoEventLoopand deletes the file.Why?
Graceful shutdown requires graceful recovery on restart, which means we need to load publishes back from file.
Trials Performed
Spinned up docker instance and used qa-scripts like
qa-scripts/persistence.shto test out the functionality.