wasm-tools: load new tag format #10
Conversation
|
thank you so much for the PR (and all the work you do for open source community). if you have a few mins, could you please add a testcase in https://github.com/bytecodealliance/actions/blob/main/.github/workflows/wasmtools-tests.yml for the new wasm-tools format. (or I am happy to add it myself in a follow up PR).
what do you think would be better: to accept version without v prefix or update actions to support both formats (with/without prefix) to avoid any confusions. thanks |
|
Thanks for making this! I have a few projects that use it—it’s been handy to have an official setup action for |
Fixes bytecodealliance#8. wasm-tools: try legacy tag format, then new tag format; strip v from version number .github/workflows/wasmtools-tests: add tests for 1.200.0 and vN wasmtools -> wasm-tools To match the crate and executable name. .github/workflows/wasm-tools-tests: fix detection wasm-tools: fix lint issues wasmtime: accept version values prefixed with 'v' wit-bindgen: support new tag format, versions with v .github/workflows: fix failing tests wit-bindgen: that's what I get for copy and paste early in the morning wasmtime: correct tag format wasmtime, wit-bindgen: version string used in copy wit-bindgen: mutate version variable depending on tag format wit-bindgen: try this wit-bindgen: try separate vVersion variable wit-bindgen: try this wit-bindgen: use separate binVersion .github/workflows: rename build jobs with shorter names So the full matrix names can be seen in GitHub Actions runner sidebar .github/workflows: move version in front of os for display purposes .github/workflows: break out tests for v-prefixed versions
|
OK, tests pass. I rebased and squashed. |
|
Would it make sense to bump the release to I can update the README to reflect that and the changes to the accepted version spec. |
|
Hi @ydnar , thank you for making the changes and adding the tests. given these changes are backward compatible (please correct me I misread this), I think we can just make a patch release. In anycase, for Thanks |
|
Please let me know if you have opinion about patch vs minor release, and I will cut the new release accordingly. thanks again. |
|
It's backwards compatible as far as I can tell from the tests. Any version is probably fine. Do you want to update the README? |
|
yeah, that would be great. thank you. |
- Add wit-bindgen - Change wasmtime version argument to omit the v prefix - Markdown lint/format/remove trailing whitespace - Add backticks around names
|
Done! |
Fixes #8.
v1.0.0or1.0.0