Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't apply a mask on the flags in PermissionsExt. #256

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Don't apply a mask on the flags in PermissionsExt. #256

merged 2 commits into from
Jun 23, 2022

Conversation

sunfishcode
Copy link
Member

For consistency with std, don't apply a mask to the flags bits in
PermissionsExt.

Fixes #249.

@sunfishcode
Don't apply a mask on the flags in PermissionsExt.
fe33af7 
For consistency with std, don't apply a mask to the flags bits in
`PermissionsExt`.

Fixes #249.
@sunfishcode
Fix warnings.
f818b02
@sunfishcode sunfishcode mentioned this pull request Jun 21, 2022
Closed
@sunfishcode
Copy link
Member Author

I find this a little surprising, but it's what std does, and cap-std intends to match std.

@sunfishcode sunfishcode merged commit e7e906c into main Jun 23, 2022
@sunfishcode sunfishcode deleted the sunfishcode/no-mask-perm-flags branch June 23, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PermissionsExt::mode masks off the format bits
1 participant
@sunfishcode