Update to io-lifetimes 1.0. #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/io-lifetimes-1.0
branch
2 times, most recently
from
d5314d4
to
74729fa
Compare
|
Once async-rs/async-std#1036 lands and is released, we'll be able to re-enable cap-async-std here. |
This was referenced Aug 23, 2022
This converts to the new traits, with `From` instead of `IntoFd` and `FromFd`. This currently depends on cap-async-std being disabled, since async-std doesn't yet have the io-safety trait impls yet.
sunfishcode
force-pushed
the
sunfishcode/io-lifetimes-1.0
branch
from
14af59c
to
0e14391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts to the new traits, with
Frominstead ofIntoFdandFromFd.This currently depends on cap-async-std being disabled, since async-std
doesn't yet have the io-safety trait impls yet.