Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target wasm32-wasi by default #48

Closed
peterhuene opened this issue Feb 12, 2023 · 3 comments · Fixed by #55
Closed

Target wasm32-wasi by default #48

peterhuene opened this issue Feb 12, 2023 · 3 comments · Fixed by #55
Labels
enhancement New feature or request

Comments

@peterhuene
Copy link
Member

We should switch from targeting wasm32-unknown-unknown and target wasm32-wasi by default and automatically link in an adapter for users (at least until preview2 is supported natively in the rust toolchain).
@peterhuene peterhuene added the enhancement New feature or request label Feb 12, 2023
@jeffparsons
Copy link
Contributor

at least until preview2 is supported natively in the rust toolchain

Out of curiosity, is anybody working on this already, or is preview2 still too far out for that to make sense yet?

@sunfishcode
Copy link
Member

at least until preview2 is supported natively in the rust toolchain

Out of curiosity, is anybody working on this already, or is preview2 still too far out for that to make sense yet?

See rust-lang/compiler-team#594 which was just posted 😃

@jeffparsons
Copy link
Contributor

Oooh, that is exciting!

peterhuene added a commit to peterhuene/cargo-component that referenced this issue Feb 28, 2023
@peterhuene
Target wasm32-wasi by default.
aff2731 
This commit makes `cargo component` target `wasm32-wasi` by default, using a
local preview1 adapter to adapter to a preview2 version of WASI.

Closes bytecodealliance#48.
peterhuene added a commit to peterhuene/cargo-component that referenced this issue Feb 28, 2023
@peterhuene
Target wasm32-wasi by default.
0c062d9 
This commit makes `cargo component` target `wasm32-wasi` by default, using a
local preview1 adapter to adapter to a preview2 version of WASI.

Closes bytecodealliance#48.
peterhuene added a commit to peterhuene/cargo-component that referenced this issue Feb 28, 2023
@peterhuene
Target wasm32-wasi by default.
0c44294 
This commit makes `cargo component` target `wasm32-wasi` by default, using a
local preview1 adapter to adapt to a preview2 version of WASI.

Closes bytecodealliance#48.
@peterhuene peterhuene mentioned this issue Feb 28, 2023
Merged
peterhuene added a commit to peterhuene/cargo-component that referenced this issue Mar 2, 2023
@peterhuene
Target wasm32-wasi by default.
f2571c7 
This commit makes `cargo component` target `wasm32-wasi` by default, using a
local preview1 adapter to adapt to a preview2 version of WASI.

Closes bytecodealliance#48.
peterhuene added a commit that referenced this issue Mar 3, 2023
@peterhuene
Target wasm32-wasi by default. (#55)
b0ba1f7 
* Add preview1 adapter module.

The release version is `0c6290c0613e68188e0476cef6c23874528acd81`.

* Target `wasm32-wasi` by default.

This commit makes `cargo component` target `wasm32-wasi` by default, using a
local preview1 adapter to adapt to a preview2 version of WASI.

Closes #48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Target wasm32-wasi by default. peterhuene/cargo-component
3 participants
@jeffparsons @peterhuene @sunfishcode