Fix bindings version warning and upgrade command. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought the |
jeffparsons
reviewed
Nov 9, 2023
jeffparsons
reviewed
Nov 9, 2023
|
(Sorry if my comments here don't quite make sense; I'm posting from mobile in the middle of the night. Maybe I shouldn't do that...) |
jeffparsons
reviewed
Nov 10, 2023
This commit fixes the warning emitted when a mismatched bindings version crate is detected such that it no longer warns when the bindings crate version is compatible, but not the same version (i.e. `0.4.1` when cargo-component is `0.4.0`). Likewise, the `upgrade` command no longer attempts to downgrade the version of the bindings crate when it would otherwise be compatible. The upgrade tests no longer attempt the install, which require a long time to just verify that a `cargo install cargo-component` would succeed, which isn't terribly useful.
* Remove outdated comment in upgrade command. * Properly handle when the bindings crate is newer than cargo-component: * Emit a warning instructing the upgrade of cargo-component. * Skip updating `Cargo.toml` for `cargo component upgrade`.
peterhuene
force-pushed
the
fix-warning
branch
from
1fb1d3d
to
706c236
Compare
jeffparsons
approved these changes
Nov 10, 2023
|
As you are a previous contributor, I'm happy to rely on your review, given it is related to the feature you added previously. I appreciate the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the warning emitted when a mismatched bindings version crate is detected such that it no longer warns when the bindings crate version is compatible, but not the same version (i.e.
0.4.1when cargo-component is0.4.0).Likewise, the
upgradecommand no longer attempts to downgrade the version of the bindings crate when it would otherwise be compatible.The upgrade tests no longer attempt the install, which require a long time to just verify that a
cargo install cargo-componentwould succeed, which isn't terribly useful.The warning and upgrade command now both detect when cargo-component is outdated and instruct the user appropriately.