Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Update VeriWasm version #684

Merged
merged 3 commits into from Oct 30, 2021
Merged

Update VeriWasm version #684

merged 3 commits into from Oct 30, 2021

Conversation

enjhnsn2
Copy link
Contributor

This updates lucet to use the most up-to-date version of VeriWasm that runs clean on lucet's fuzzer.

pchickey
pchickey previously approved these changes Oct 26, 2021
@cfallin
Copy link
Member

cfallin commented Oct 26, 2021

Thanks very much @enjhnsn2 for all the work here!

pchickey
pchickey previously approved these changes Oct 27, 2021
@cfallin
Copy link
Member

cfallin commented Oct 27, 2021

The CircleCI jobs on Linux are failing with the exceedingly cryptic error from wabt-sys:

 CMake Warning at CMakeLists.txt:158 (message):
    Error running `file` command on dummy executable

I'm looking into this a bit -- initially at least I notice that it's an old version (v0.6.1 vs latest v0.8.0) of the crate...

@cfallin
Copy link
Member

cfallin commented Oct 27, 2021

Updating to latest wabt also doesn't help -- I pushed a commit to do this but got the same error: build results

I'm also unable to reproduce the error locally on Linux. Additionally it seems unlikely to be an issue with external environment of some sort (e.g. download at some URL became new version silently or somesuch) as another PR (#683) just passed CI and merged yesterday. @enjhnsn2 or @pchickey any other ideas?

@pchickey
Copy link
Contributor

That error looks like the cmake on the builder isnt new enough. I have no idea why we didn't encounter the same error in 683, though.

@cfallin
Copy link
Member

cfallin commented Oct 28, 2021

@enjhnsn2 I got a clean CI build on CircleCI with one more commit to update the Docker image to Ubuntu 20.04.... could you pull in the commit from this run? link

(I think that CircleCI keys CI status on commit hash, so if you push exactly my commit to this PR's branch, it should get a green check automatically)

@enjhnsn2
Copy link
Contributor Author

I updated with the Docker image commit and it does seem to have triggered CircleCI 👍

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience with CI! Looks good to merge now.

@cfallin cfallin merged commit 5981633 into bytecodealliance:main Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants