Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Implement file append functionality. #50

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Implement file append functionality. #50

merged 2 commits into from
Jan 9, 2023

Conversation

sunfishcode
Copy link
Member

  • In the preview1-to-preview2 polyfill, using append_via_stream.
  • In the host implementation, using a new system-interface FileIoExt::append function.

dicej
dicej approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. We'll want to add runtime tests for both writing and appending to actually exercise this stuff.

@sunfishcode
Implement file append functionality.
dcaa950 
 - In the preview1-to-preview2 polyfill, using `append_via_stream`.
 - In the host implementation, using a new system-interface `FileIoExt::append` function.
@sunfishcode
Add a basic testcase.
da668bd
@sunfishcode
Copy link
Member Author

I've now added a basic test.

@sunfishcode sunfishcode merged commit d56b897 into main Jan 9, 2023
@sunfishcode sunfishcode deleted the sunfishcode/append branch January 9, 2023 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dicej dicej dicej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sunfishcode @dicej