Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some rerun-if-env-changed lines from build.rs. #576

Merged
merged 1 commit into from
Mar 29, 2023

Commits on Mar 29, 2023

  1. Remove some rerun-if-env-changed lines from build.rs.

    Now that we appear to have a known-working fix for #526, we can
    investigate relaxing the fix. If #526 reappears, we now have a
    known-working state we can quickly revert to.
    
    Reports in #562 and #575 are that having rerun-if-env-changed=RUSTC
    and rerun-if-env-changed=RUSTC_WRAPPER are triggering spurious rebuilds
    in some situations, so remove these. In theory, cargo should already be
    aware of these environment variables. In practice, there were reports of
    build failures which had the appearance of using an older version of
    rustc with build.rs output from a newer version of rustc, and it wasn't
    clear what was happening. But, it's possible that #563 fixes the issue
    properly. So let's try removing these rerun-if-env-changed lines, and
    see if the problem resurfaces.
    
    And, rerun-if-env-changed=TARGET is explicitly documented as being
    unnecessary [here].
    
    [here]: https://doc.rust-lang.org/cargo/reference/build-scripts.html
    sunfishcode committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    17ba32a View commit details
    Browse the repository at this point in the history