add execv #97

nivkner · 2021-10-28T18:24:31Z

this adds execv to runtime, since its use is limited without fork which is also in runtime.

sunfishcode

It was a little surprising at first to see two allocations for the argv array, but I now see what the code is doing and it makes sense :-).

src/runtime.rs

src/imp/linux_raw/syscalls.rs

src/runtime.rs

nivkner force-pushed the add_execvp branch 2 times, most recently from 7140970 to 87235ca Compare October 28, 2021 20:16

nivkner changed the title ~~add execvp~~ add execv Oct 28, 2021

nivkner force-pushed the add_execvp branch 2 times, most recently from c905924 to 96e997c Compare October 28, 2021 20:39

add execv

999c21d

nivkner force-pushed the add_execvp branch from 96e997c to 999c21d Compare October 28, 2021 20:41

sunfishcode reviewed Oct 28, 2021

View reviewed changes

src/runtime.rs Show resolved Hide resolved

src/imp/linux_raw/syscalls.rs Outdated Show resolved Hide resolved

src/imp/linux_raw/syscalls.rs Outdated Show resolved Hide resolved

src/runtime.rs Outdated Show resolved Hide resolved

nivkner added 2 commits October 29, 2021 00:13

use concrete type for syscalls::execv

50cce3f

allow setting environment variables in exec with execve

248375a

sunfishcode merged commit 334c4cf into bytecodealliance:main Oct 29, 2021

sunfishcode mentioned this pull request Oct 29, 2021

std::process::Command and I/O safety #100

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add execv #97

add execv #97

nivkner commented Oct 28, 2021 •

edited

Loading

sunfishcode left a comment

add execv #97

add execv #97

Conversation

nivkner commented Oct 28, 2021 • edited Loading

sunfishcode left a comment

Choose a reason for hiding this comment

nivkner commented Oct 28, 2021 •

edited

Loading