Skip to content

Commit

Permalink
Disable '-D warnings` in CI. (#105)
Browse files Browse the repository at this point in the history
Disable '-D warnings` in CI to avoid `unexpected_cfgs` failures in a way
that doesn't break Rust 1.34.
  • Loading branch information
sunfishcode committed Jun 27, 2024
1 parent 1424ce0 commit 06071fd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
9 changes: 6 additions & 3 deletions .github/actions/install-rust/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@ child_process.execFileSync('rustup', ['default', toolchain]);

// Deny warnings on CI to keep our code warning-free as it lands in-tree. Don't
// do this on nightly though since there's a fair amount of warning churn there.
if (!toolchain.startsWith('nightly')) {
set_env("RUSTFLAGS", "-D warnings");
}
//
// Disable this for now to avoid `unexpected_cfgs` in a way that works with
// Rust 1.34.
//if (!toolchain.startsWith('nightly')) {
// set_env("RUSTFLAGS", "-D warnings");
//}

// Save disk space by avoiding incremental compilation, and also we don't use
// any caching so incremental wouldn't help anyway.
Expand Down
1 change: 1 addition & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
)
)]
#![cfg_attr(not(feature = "std"), no_std)]

#[cfg(not(feature = "std"))]
extern crate alloc;
#[cfg(feature = "std")]
Expand Down

0 comments on commit 06071fd

Please sign in to comment.