Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document engine flags for enabling wasi-nn #35

Closed
abrown opened this issue Apr 21, 2021 · 2 comments
Closed

Document engine flags for enabling wasi-nn #35

abrown opened this issue Apr 21, 2021 · 2 comments

Comments

@abrown
Copy link
Collaborator

abrown commented Apr 21, 2021

The documentation does not make it clear that currently one must build Wasmtime with a special flag --features wasi-nn in order to enable the wasi-nn features. This is present in the GitHub workflow but it should be made explicit somewhere (perhaps in the top-level README and linked to from the as and rust READMEs?).

@abrown
Copy link
Collaborator Author

abrown commented Apr 30, 2021

The --features wasi-nn flag will no longer be necessary once the next version of Wasmtime is released (v0.27.0). After bytecodealliance/wasmtime#2859, wasi-nn can be enabled by passing the --wasi-modules=experimental-wasi-nn flag at runtime. After the next Wasmtime release, we should:

  • document that the --wasi-modules flag is necessary,
  • update this project's CI to use the newer version of Wasmtime
  • and update the build.sh script to use the --wasi-modules flag.

@brianjjones
Copy link
Collaborator

Docs have been updated. And the CI uses the build.sh script to test, and that script has been updated with the needed flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants