-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to use tagged unions #41
Conversation
54d98dc
to
6d66e84
Compare
@kubkon many thanks, ive rebased |
054bb7f
to
9c0d287
Compare
src/lib_generated.rs
Outdated
@@ -6,7 +6,7 @@ use core::mem::MaybeUninit; | |||
|
|||
pub use crate::error::Error; | |||
pub type Result<T, E = Error> = core::result::Result<T, E>; | |||
pub type Size = usize; | |||
pub type Size = u32; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intentional? IIRC this was a convenience from before because usize
is used so ubiquitously in Rust right nwo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a question about usize
but otherwise lgtm
Oops, that was not intentional, I'll revert it. We now have BuiltinType::Size in witx but the snapshot isnt using it yet, so I'll leave the hack to make the target of the type named |
along with a comment describing when its safe to remove
96382c8
to
1f49584
Compare
👍 |
Move `CLOCK_REALTIME` to be the first `clockid_t` value. This change reflects the definitions used in [existing practice], so this patch updates the `wasi_unstable_preview0` and `wasi_unstable` definitions as well. This is the same change as bytecodealliance#41, but updated for the WASI repository's new phases directory structure. [existing practice]: https://github.com/CraneStation/wasi-libc/blob/master/libc-bottom-half/headers/public/wasi/core.h#L42
DO NOT MERGE until upstream WASI changes are merged into master, and submodule is pointed at master.
Implements WebAssembly/WASI#220