-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fd_advise
always succeeds
#3322
Comments
yagehu
added a commit
to yagehu/wasm-micro-runtime
that referenced
this issue
Apr 17, 2024
`posix_fadvise()` returns 0 on success and the errno on error. This commit fixes the handling of the return value such that it does not always succeeds. fixes bytecodealliance#3322
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this issue
May 1, 2024
`posix_fadvise()` returns 0 on success and the errno on error. This commit fixes the handling of the return value such that it does not always succeeds. Fixes bytecodealliance#3322.
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this issue
May 2, 2024
`posix_fadvise()` returns 0 on success and the errno on error. This commit fixes the handling of the return value such that it does not always succeeds. Fixes bytecodealliance#3322. Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this issue
May 27, 2024
`posix_fadvise()` returns 0 on success and the errno on error. This commit fixes the handling of the return value such that it does not always succeeds. Fixes bytecodealliance#3322.
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this issue
May 27, 2024
`posix_fadvise()` returns 0 on success and the errno on error. This commit fixes the handling of the return value such that it does not always succeeds. Fixes bytecodealliance#3322. Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subject of the issue
Calling
fd_advise
always succeeds, even with very large offset, length, or a combination of them.Test case
Your environment
64-bit x86 Fedora Linux
WAMR is latest HEAD.
Steps to reproduce
Use
wat2wasm
to encode the above WAT code and run it withiwasm
mounting some directory:Expected behavior
It should print some non-zero error code, say 28.
Actual behavior
It prints 0.
Extra Info
I will raise a PR that fixes this.
The text was updated successfully, but these errors were encountered: