Fix bh_assert on 64-bit platforms #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganek
force-pushed
the
loganek/fix-memory-sanitizer
branch
from
e031836
to
27a02b7
Compare
loganek
changed the title
In some cases (for me, every time I use memory sanitizer) the memory address of some of the variables has 4 least significant bytes set to zero. Because we cast the pointer to int, we look only at 4 (at least on my system, but I guess on many other systems too) least significant bytes; the assertion fails because 4 least significant bytes are 0. I change bh_assert implementation so it casts to int64_t and it works well with 64-bit architectures.
loganek
force-pushed
the
loganek/fix-memory-sanitizer
branch
from
27a02b7
to
fdf8a05
Compare
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
In some cases, the memory address of some variables may have 4 least significant bytes set to zero. Because we cast the pointer to int, we look only at 4 least significant bytes; the assertion may fail because 4 least significant bytes are 0. Change bh_assert implementation to cast the assert expr to int64_t and it works well with 64-bit architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (for me, every time I use memory sanitizer) the memory address of some of the variables has 4 least significant bytes set to zero. Because we cast the pointer to int, we look only at 4 (at least on my system, but I guess on many other systems too) least significant bytes; the assertion fails because 4 least significant bytes are 0.
I change bh_assert implementation so it casts to int64_t and it works well with 64-bit architectures.