Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document the summary of two pthread implementations #2104

Merged
merged 2 commits into from
Apr 4, 2023
Merged

document the summary of two pthread implementations #2104

merged 2 commits into from
Apr 4, 2023

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Apr 4, 2023

No description provided.

@wenyongh
Copy link
Contributor

wenyongh commented Apr 4, 2023

Thanks @yamt ! We are just wondering how to add the document of wasi-threads, and add an item to the Key features list of README.md. How about we adding a line in README.md after Multi-thread, pthread APIs and thread management by referring to your document:
- [wasi-threads](./doc/pthread_impls.md#wasi-threads-new), ref to [document](./doc/pthread_impls.md#wasi-threads-new) and [sample](samples/wasi-threads)

And provide more detail document about wasi-threads in the future if needed.

@yamt
Copy link
Collaborator Author

yamt commented Apr 4, 2023

Thanks @yamt ! We are just wondering how to add the document of wasi-threads, and add an item to the Key features list of README.md. How about we adding a line in README.md after Multi-thread, pthread APIs and thread management by referring to your document: - [wasi-threads](./doc/pthread_impls.md#wasi-threads-new), ref to [document](./doc/pthread_impls.md#wasi-threads-new) and [sample](samples/wasi-threads)

it makes sense. do you want me to do it in this PR?

@wenyongh
Copy link
Contributor

wenyongh commented Apr 4, 2023

Thanks @yamt ! We are just wondering how to add the document of wasi-threads, and add an item to the Key features list of README.md. How about we adding a line in README.md after Multi-thread, pthread APIs and thread management by referring to your document: - [wasi-threads](./doc/pthread_impls.md#wasi-threads-new), ref to [document](./doc/pthread_impls.md#wasi-threads-new) and [sample](samples/wasi-threads)

it makes sense. do you want me to do it in this PR?

Yes, appreciated!

@yamt
Copy link
Collaborator Author

yamt commented Apr 4, 2023

Thanks @yamt ! We are just wondering how to add the document of wasi-threads, and add an item to the Key features list of README.md. How about we adding a line in README.md after Multi-thread, pthread APIs and thread management by referring to your document: - [wasi-threads](./doc/pthread_impls.md#wasi-threads-new), ref to [document](./doc/pthread_impls.md#wasi-threads-new) and [sample](samples/wasi-threads)

it makes sense. do you want me to do it in this PR?

Yes, appreciated!

done

@wenyongh wenyongh merged commit e7b988e into bytecodealliance:main Apr 4, 2023
wenyongh added a commit to wenyongh/wasm-micro-runtime that referenced this pull request Apr 4, 2023
@wenyongh
Merge pull request #744 from bytecodealliance/main
c83c667 
Document the summary of two pthread implementations (bytecodealliance#2104)
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@yamt
Document the summary of two pthread implementations (bytecodealliance…
6e3f91a 
…#2104)

And add `wasi-threads` to the key feature list in README.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yamt @wenyongh