Define the GC runtime APIs to export #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/iwasm/include/gc_export.h
Outdated
| * this type of variable so that they can be traced when GC occurs. | ||
| * Before using such a variable, it must be pushed onto the stack | ||
| * (implemented as a chain) of such variables, and before leaving the | ||
| * frame of the variables, they must be poped from the stack. |
There was a problem hiding this comment.
Suggested change
| * frame of the variables, they must be poped from the stack. | |
| * frame of the variables, they must be popped from the stack. |
core/iwasm/include/gc_export.h
Outdated
| * Check whether a defined type is a function type | ||
| */ | ||
| WASM_RUNTIME_API_EXTERN bool | ||
| wasm_defined_type_is_func_type(const wasm_defined_type_t def_type1); |
There was a problem hiding this comment.
What does the 1 in def_type1 mean?
There was a problem hiding this comment.
typo, should be def_type
core/iwasm/include/gc_export.h
Outdated
| */ | ||
| WASM_RUNTIME_API_EXTERN wasm_ref_type_t | ||
| wasm_func_type_get_result_type(const wasm_func_type_t func_type, | ||
| uint32 param_idx); |
There was a problem hiding this comment.
Suggested change
| uint32 param_idx); | |
| uint32 result_idx); |
core/iwasm/include/gc_export.h
Outdated
| /** | ||
| * Get parameter count of a function type | ||
| */ | ||
| WASM_RUNTIME_API_EXTERN uint32 |
There was a problem hiding this comment.
In wasm_export.h, we use uint32_t rather than uint32, should we keep the same rule in this file?
There was a problem hiding this comment.
yes, had better use xxx_t types
core/iwasm/include/gc_export.h
Outdated
| wasm_obj_is_anyref_obj(const wasm_obj_t obj); | ||
|
|
||
| /** | ||
| * Check whether an object is a struct object, or, a i31/struct/array object |
There was a problem hiding this comment.
Suggested change
| * Check whether an object is a struct object, or, a i31/struct/array object | |
| * Check whether an object is a struct object, or, an i31/struct/array object |
core/iwasm/include/gc_export.h
Outdated
| wasm_obj_is_internal_obj(const wasm_obj_t obj); | ||
|
|
||
| /** | ||
| * Check whether an object is a eq object |
There was a problem hiding this comment.
Suggested change
| * Check whether an object is a eq object | |
| * Check whether an object is an eq object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.