Add --enable-gc option to WAMRC #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
force-pushed
the
dev/gc_refactor
branch
6 times, most recently
from
e6c261d
to
75751a0
Compare
no1wudi
force-pushed
the
dev/gc_refactor
branch
4 times, most recently
from
32d433d
to
e59faf7
Compare
wenyongh
reviewed
May 12, 2023
no1wudi
force-pushed
the
dev/gc_refactor
branch
2 times, most recently
from
e3ca208
to
614a4e9
Compare
wenyongh
reviewed
May 15, 2023
wamr-compiler/main.c
Outdated
| @@ -57,12 +57,13 @@ print_help() | |||
| printf(" --disable-simd Disable the post-MVP 128-bit SIMD feature:\n"); | |||
| printf(" currently 128-bit SIMD is supported for x86-64 and aarch64 targets,\n"); | |||
| printf(" and by default it is enabled in them and disabled in other targets\n"); | |||
| printf(" --disable-ref-types Disable the MVP reference types feature\n"); | |||
| printf(" --disable-ref-types Disable the MVP reference types feature, it will be force disabled if GC enabled\n"); | |||
There was a problem hiding this comment.
How about it will be disabled forcibly?
There was a problem hiding this comment.
be force disabled should be a grammar mistake
wenyongh
reviewed
May 15, 2023
The runtime instance memory layout changed with GC enabled. With this patch GC enabled for WAMRC, but keep compatible for iwasm wether it enabled GC or not for non-GC wasm module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime instance memory layout changed with GC enabled. With this patch GC enabled for WAMRC, but keep compatible for iwasm wether it enabled GC or not for non-GC wasm module.
It may waste some memory for iwasm without GC support since the GC relative fileds are always here, let's do optimization until
AOT fully support GC.