Enable static PGO for Linux SGX #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Jun 7, 2023
| execute_process( | ||
| COMMAND bash -c "sed -i -E 's/^WAMR_BUILD_STATIC_PGO = .*/WAMR_BUILD_STATIC_PGO = ${WAMR_BUILD_STATIC_PGO}/g' ${CMAKE_CURRENT_SOURCE_DIR}/enclave-sample/Makefile" | ||
| OUTPUT_VARIABLE cmdOutput | ||
| ) |
There was a problem hiding this comment.
Had better handle it like WAMR_BUILD_SGX_IPFS EQUAL and WAMR_BUILD_LIB_RATS below. e.g.
if (WAMR_BUILD_STATIC_PGO EQUAL 1)
...
else ()
...
endif ()| if [ "$1" = "--sgx" ] && [ "$PLATFORM" = "linux" ]; then | ||
| IWASM="../../../product-mini/platforms/${PLATFORM}-sgx/enclave-sample/iwasm" | ||
| WAMRC="${WAMRC} -sgx" | ||
| . /opt/intel/sgxsdk/environment |
There was a problem hiding this comment.
No need to add this line, developer may install sgxsdk in other place.
| WAMRC="../../../wamr-compiler/build/wamrc" | ||
| if [ "$1" = "--sgx" ] && [ "$PLATFORM" = "linux" ]; then | ||
| IWASM="../../../product-mini/platforms/${PLATFORM}-sgx/enclave-sample/iwasm" | ||
| WAMRC="${WAMRC} -sgx" |
There was a problem hiding this comment.
Had better
if [ "$1" = "--sgx" ]; then
IWASM="$PWD/../../../product-mini/platforms/linux-sgx/enclave-sample/iwasm"
WAMRC="$PWD/../../../wamr-compiler/build/wamrc -sgx"
else
IWASM="$PWD/../../../product-mini/platforms/${PLATFORM}/build/iwasm"
WAMRC="$PWD/../../../wamr-compiler/build/wamrc"
fi
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Enable static PGO for Linux SGX and update the related benchmarks test scripts and documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable static PGO for Linux SGX
Update related benchmarks test scripts and readmes