Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable windows x86-32 AOT relocations #2285

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

wenyongh
Copy link
Contributor

Implement relocation types IMAGE_REL_I386_DIR32 and IMAGE_REL_I386_REL32,
fix find symbol of AOT function, and implement symbol __aulldiv.

@yamt
Copy link
Collaborator

yamt commented Jun 15, 2023

the changes look reasonable to me.
(i'm ignorant of these windows specific things though)

@wenyongh
Copy link
Contributor Author

the changes look reasonable to me. (i'm ignorant of these windows specific things though)

Yes, I think it should be good, I just collect the changes mentioned in #2235, it should have been tested by the author.

@wenyongh wenyongh merged commit 0ac5f20 into bytecodealliance:main Jun 16, 2023
480 checks passed
@wenyongh wenyongh deleted the fix_win32_reloc branch June 19, 2023 13:57
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Implement relocation types IMAGE_REL_I386_DIR32 and IMAGE_REL_I386_REL32,
fix failure to find AOT function symbol, and implement symbol __aulldiv.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants