Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dockerfile linter warnings #2291

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

TianlongLiang
Copy link
Contributor

Should we also consider adding a CI that uses hadolint to check Dockerfile?

@yamt
Copy link
Collaborator

yamt commented Jun 15, 2023

is "replace curl with wget" change a recommendation from hadolint?
do you still need to install curl after the change?
i feel a little sad because i personally prefer curl over wget. :-)

@TianlongLiang
Copy link
Contributor Author

Yes, it's a warning in the hadolint.
Since it's a devdocker, I think maybe should keep it installed in case anyone wants to use curl inside the container.

@yamt
Copy link
Collaborator

yamt commented Jun 15, 2023

Yes, it's a warning in the hadolint. Since it's a devdocker, I think maybe should keep it installed in case anyone wants to use curl inside the container.

ok. thank you for explanation.

@wenyongh
Copy link
Contributor

Hi @tonibofarull, this PR changes some docker file of wasi-nn, could you help check whether it is good to you? Thanks.

Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 8f82b1e into bytecodealliance:main Jun 15, 2023
480 checks passed
@TianlongLiang TianlongLiang deleted the dev/dockerfile_lint_fix branch June 16, 2023 03:25
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants