Add "--enable-builtin-intrinsics=<...>" option to wamrc #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
force-pushed
the
intrinsic
branch
2 times, most recently
from
14e41a7
to
8ff7999
Compare
wenyongh
reviewed
Jul 5, 2023
wamr-compiler/main.c
Outdated
| @@ -68,6 +68,12 @@ print_help() | |||
| printf(" --xip A shorthand of --enalbe-indirect-mode --disable-llvm-intrinsics\n"); | |||
| printf(" --enable-indirect-mode Enalbe call function through symbol table but not direct call\n"); | |||
| printf(" --disable-llvm-intrinsics Disable the LLVM built-in intrinsics\n"); | |||
| printf(" --enable-builtin-intrinsics=<i64.common,f64.common>\n"); | |||
| printf(" Enable the specified built-in intrinsics, it will override the default settings.\n"); | |||
There was a problem hiding this comment.
Seems a little too long this line, can we put settings. to next line?
wenyongh
reviewed
Jul 5, 2023
core/iwasm/aot/aot_intrinsic.c
Outdated
| } | ||
|
|
||
| /* Handle other single items */ | ||
| for (uint32 i = 0; i < g_intrinsic_count; i++) { |
There was a problem hiding this comment.
Had better declare uint32 i at the beginning of this function or the beginning of { ... }.
wenyongh
reviewed
Jul 5, 2023
wamr-compiler/main.c
Outdated
Comment on lines
73
to
74
| printf(" settings.\n"); | ||
| printf(" It only takes effect when --disable-llvm-intrinsics is set.\n"); |
There was a problem hiding this comment.
Sorry, I meant to merge the next two lines into one:
printf(" Enable the specified built-in intrinsics, it will override the default\n");
printf(" settings. It only takes effect when --disable-llvm-intrinsics is set.\n");Do you think it is better?
There was a problem hiding this comment.
OK, let's merge them
wenyongh
reviewed
Jul 5, 2023
core/iwasm/aot/aot_intrinsic.c
Outdated
|
|
||
| /* Handle 'all' group */ | ||
| if (strstr(comp_ctx->builtin_intrinsics, "all")) { | ||
| for (uint32 i = 0; i < g_intrinsic_count; i++) { |
There was a problem hiding this comment.
The variable shadows the previous one. Should remove uint32 here.
wamr-compiler/main.c
Outdated
| @@ -68,6 +68,12 @@ print_help() | |||
| printf(" --xip A shorthand of --enalbe-indirect-mode --disable-llvm-intrinsics\n"); | |||
| printf(" --enable-indirect-mode Enalbe call function through symbol table but not direct call\n"); | |||
| printf(" --disable-llvm-intrinsics Disable the LLVM built-in intrinsics\n"); | |||
| printf(" --enable-builtin-intrinsics=<i64.common,f64.common>\n"); | |||
| printf(" Enable the specified built-in intrinsics, it will override the default\n"); | |||
| printf(" settings.It only takes effect when --disable-llvm-intrinsics is set.\n"); | |||
There was a problem hiding this comment.
Had better add an space before It
wenyongh
reviewed
Jul 6, 2023
Change-Id: I7ac4b0d5f06133cf737c29b22b21a86a08e1e863
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…liance#2341) Refer to doc/xip.md for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to xip.md for detail