-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker image for latest version of external libraries & tools #2374
Update Docker image for latest version of external libraries & tools #2374
Conversation
3eb0260
to
ba506bd
Compare
ba506bd
to
97bd061
Compare
Please make sure to pass hadolint check. |
Hi, I run hadolint check on the Dockerfile for you, there are some warnings, you can check too by first pulling the docker image of hadolint, then running the check in the # pull docker images
docker pull hadolint/hadolint:latest
# hadolint check
git ls-files --exclude="*Dockerfile*" --cached --ignored | xargs -I filename zsh -c "echo filename; docker run --rm -i hadolint/hadolint:2.10.0 < filename; echo \"\n\""
# output
-:13 DL3009 info: Delete the apt-get lists after installing something
-:14 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
-:14 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
-:96 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
-:96 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
-:96 DL3015 info: Avoid additional packages by specifying `--no-install-recommends` |
Hello @lum1n0us and @TianlongLiang, thanks for the output, I fixed Dockerfile linter warnings/infos. I may suggest that maybe it would be more helpful to run Hadolint check on Github actions when someone has changed one of Dockerfiles in the repository. Because I was not aware of that linter was run before changing anything on Dockerfile. |
Yes, a CI for hadolint linter to scan over Dockerfiles is definitely worth consideration, I will be working on it |
LGTM |
…ytecodealliance#2374) Devcontainer is too old to catch up the latest versions of dependencies. This PR updates the libraries & tools that WASM environment requires for Docker image. **Impediments:** - LLVM 16 can not be retrieved directly by using shell command as provided before. So we upgrade all tools manually as a workaround and just put LLVM issue URL as a comment in the script. **Improvements:** - Use `Debian 12 (Bookworm)` as a base image instead of `Ubuntu 20.04`. - `GCC9` upgraded to `GCC12`. - `LLVM14` upgraded to `LLVM16`. - `Clang10` upgraded to `Clang10`. - `Binaryen111` upgraded to `Binaryen114`. - `WASI-19` upgraded to `WASI-20` - `WABT-1.0.29` upgraded to `WABT-1.0.33` - `Bazelisk-1.12.0` upgraded to `Bazelisk-1.17.0` - `GithubCLI-2.20.2` upgraded to `GithubCLI-2.32.0` - `NodeJS-19.x` upgraded to `NodeJS-20.x` - `EMSDK-3.0.0` upgraded to `EMSDK-3.1.43` **Notes:** `Python 2.7` is removed due to no support anymore and not found in the repository.
Devcontainer seems to old to catch up the latest versions of dependencies. So, I updated the libraries & tools if WASM environment requires for Docker image.
Impediments:
Improvements:
Debian 12 (Bookworm)
as a base image instead ofUbuntu 20.04
.GCC9
upgraded toGCC12
.LLVM14
upgraded toLLVM16
.Clang10
upgraded toClang10
.Binaryen111
upgraded toBinaryen114
.WASI-19
upgraded toWASI-20
WABT-1.0.29
upgraded toWABT-1.0.33
Bazelisk-1.12.0
upgraded toBazelisk-1.17.0
GithubCLI-2.20.2
upgraded toGithubCLI-2.32.0
NodeJS-19.x
upgraded toNodeJS-20.x
EMSDK-3.0.0
upgraded toEMSDK-3.1.43
Notes:
Python 2.7
was removed due to no support anymore and not found in the repository.