Dev/gc refactor 3 #2487
Merged
Dev/gc refactor 3 #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TianlongLiang
force-pushed
the
dev/gc_refactor_3
branch
2 times, most recently
from
d356bdf
to
d0e0b15
Compare
wenyongh
reviewed
Sep 18, 2023
core/iwasm/compilation/aot_emit_gc.c
Outdated
| check_array_obj_succ)) | ||
| goto fail; | ||
|
|
||
| if (!aot_get_array_obj_length(comp_ctx, func_ctx, array_obj, &array_len)) |
There was a problem hiding this comment.
Don't call function, just generate LLVM IR of array_obj->length >> WASM_ARRAY_LENGTH_SHIFT
There was a problem hiding this comment.
This static function generates LLVM IR(the equivalent of array_obj->length >> WASM_ARRAY_LENGTH_SHIFT) rather than calling a function, it's used in 3 places so I made it into a function.
TianlongLiang
force-pushed
the
dev/gc_refactor_3
branch
from
d0e0b15
to
cf8a668
Compare
wenyongh
reviewed
Sep 26, 2023
…ated new opcodes This reverts commit 1c0b549
…apper call, load/store directly
TianlongLiang
force-pushed
the
dev/gc_refactor_3
branch
from
86a7aeb
to
ee92031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first draft of the second part of AOT GC compilation opcodes, the struct-related and array-related new opcodes:
After merging the second part, will rebase accordingly