set_exception_visitor: remove the special case for wasi proc exit #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while wasi proc exit is not a real trap, what the runtime does on it is mostly same as real traps. that is, kill the siblings threads and represent the exit/trap as the result of the "process" to the user api. there seems no reason to distinuguish it from real traps here. note that: * the target thread either doesn't care the specific exception type or ignore wasi proc exit by themselves. (clear_wasi_proc_exit_exception) * clear_wasi_proc_exit_exception only clears local exception.
wenyongh
reviewed
Sep 4, 2023
There was a problem hiding this comment.
LGTM
@eloparco, could you help review this PR? Seems the issue mentioned in #1988 was already resolved since function clear_wasi_proc_exit_exception only clears the exception of current thread, so we can spread "wasi proc exit" exception to other threads to let them exit ASAP (the terminate flag is also set to other threads).
|
Things have changed since that PR and it seems that the distinction is not needed anymore. We have multiple tests that check exception propagation and the CI is green, so we should be confident to merge. |
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…tecodealliance#2525) While wasi proc exit is not a real trap, what the runtime does on it is mostly same as real traps. That is, kill the siblings threads and represent the exit/trap as the result of the "process" to the user api. There seems no reason to distinguish it from real traps here. Note that: - The target thread either doesn't care the specific exception type or ignore wasi proc exit by themselves. (clear_wasi_proc_exit_exception) - clear_wasi_proc_exit_exception only clears local exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while wasi proc exit is not a real trap, what the runtime does on it is mostly same as real traps. that is, kill the siblings threads and represent the exit/trap as the result of the "process" to the user api. there seems no reason to distinuguish it from real traps here.
note that:
the target thread either doesn't care the specific exception type or ignore wasi proc exit by themselves. (clear_wasi_proc_exit_exception)
clear_wasi_proc_exit_exception only clears local exception.