Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch implementations of vfbinop(min,max,pmin,pax) #2584

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

lum1n0us
Copy link
Collaborator

according to the specification,

  • fNxM_pmin/max return v1 or v2 based on flt(v1,v2) result
  • fNxM_min/max return +/-NaN, +/-Inf, v1 or v2 based on more than flt(v1,v2) result

@lum1n0us
Copy link
Collaborator Author

#2561

@lum1n0us lum1n0us force-pushed the swap_impl_of_fmin_fpmin branch 2 times, most recently from 0fdaeec to 521390d Compare September 27, 2023 02:47
@lum1n0us lum1n0us marked this pull request as ready for review September 27, 2023 10:44
according to the specification,
- fNxM_pmin/max return v1 or v2 based on flt(v1,v2) result
- fNxM_min/max return +/-NaN, +/-Inf, v1 or v2 based on more than
  flt(v1,v2) result
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 3c17a36 into bytecodealliance:main Sep 28, 2023
368 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…2584)

According to the specification,
- fNxM_pmin/max returns v1 or v2 based on flt(v1,v2) result
- fNxM_min/max returns +/-NaN, +/-Inf, v1 or v2 based on more than
  flt(v1,v2) result

Fixes issue bytecodealliance#2561.
@lum1n0us lum1n0us deleted the swap_impl_of_fmin_fpmin branch May 31, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants