Abstract POSIX filesystem functions #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoraaver
force-pushed
the
posix-filesystem-functions
branch
21 times, most recently
from
9aa004e
to
1607e49
Compare
zoraaver
commented
Sep 25, 2023
zoraaver
force-pushed
the
posix-filesystem-functions
branch
2 times, most recently
from
c94244d
to
fd8398a
Compare
zoraaver
force-pushed
the
posix-filesystem-functions
branch
5 times, most recently
from
99bc902
to
1723235
Compare
yamt
reviewed
Oct 17, 2023
zoraaver
force-pushed
the
posix-filesystem-functions
branch
2 times, most recently
from
6c4f8e1
to
9120fdc
Compare
zoraaver
force-pushed
the
posix-filesystem-functions
branch
2 times, most recently
from
2a68f80
to
cc7c07a
Compare
loganek
reviewed
Oct 18, 2023
loganek
reviewed
Oct 18, 2023
zoraaver
force-pushed
the
posix-filesystem-functions
branch
2 times, most recently
from
899aaf6
to
07ed266
Compare
To allow non-POSIX platforms such as Windows to support WASI libc filesystem functionality, create a set of wrapper functions which provide a platform-agnostic interface to interact with the host filesystem. For now, the Windows implementation is stubbed but this will be implemented properly in a future PR. There are no functional changes in this change, just a reorganization of code to move any direct POSIX references out of posix.c in the libc implementation into posix_file.c under the shared POSIX sources. See bytecodealliance#2495 for a more detailed overview of the plan to port the WASI libc filesystem to Windows.
zoraaver
force-pushed
the
posix-filesystem-functions
branch
3 times, most recently
from
013166c
to
be7df3b
Compare
wenyongh
reviewed
Oct 19, 2023
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/include/wasmtime_ssp.h
Outdated
Show resolved
Hide resolved
In order to get rid of the dependency of platform headers on wasmtime_ssp.h, create a new header platform_wasi.h which defines the WASI types. The platform filesystem implementations as well as the wasi-libc code can then depend on this header without introducing any dependency issues. Also, rename and move wasi_errno.h to libc_errno.h under common platform sources since it has no depedencies except the wasi types and libc errno codes.
zoraaver
force-pushed
the
posix-filesystem-functions
branch
from
be7df3b
to
559ea99
Compare
addressed the comment 👍 |
wenyongh
merged commit fa5e9d7
into
bytecodealliance:dev/wasi-libc-windows
381 checks passed
hasheddan
added a commit
to hasheddan/wasm-micro-runtime
that referenced
this pull request
Jan 25, 2024
Follows up the change in bytecodealliance#2585 to include libc utils when targeting zephyr, which abstracts posix filesystem functions. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
To allow non-POSIX platforms such as Windows to support WASI libc filesystem functionality, create a set of wrapper functions which provide a platform-agnostic interface to interact with the host filesystem. For now, the Windows implementation is stubbed but this will be implemented properly in a future PR. There are no functional changes in this change, just a reorganization of code to move any direct POSIX references out of posix.c in the libc implementation into posix_file.c under the shared POSIX sources. See bytecodealliance#2495 for a more detailed overview of the plan to port the WASI libc filesystem to Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow non-POSIX platforms such as Windows to support WASI libc
filesystem functionality, create a set of wrapper functions which
provide a platform-agnostic interface to interact with the host
filesystem. For now, the Windows implementation is stubbed but this will
be implemented properly in a future PR. There are no functional changes
in this change, just a reorganization of code to move any direct POSIX
references out of posix.c in the libc implementation into posix_file.c
under the shared POSIX sources.
See #2495 for a
more detailed overview of the plan to port the WASI libc filesystem to Windows.