Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Strip static and shared libraries of iwasm to reduce the bin..." #2669

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Revert "Strip static and shared libraries of iwasm to reduce the bin..." #2669

merged 1 commit into from
Oct 25, 2023

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Oct 24, 2023

This reverts commit 7e3a29d.

@yamt
Revert "Strip static and shared libraries of iwasm to reduce the bina…
456654b 
…ry size (bytecodealliance#2431)"

This reverts commit 7e3a29d.

* it doesn't work for macOS. ("unrecognized option: --strip-all")

* it doesn't work for ubuntu.
  bytecodealliance#2665
@lum1n0us
Copy link
Collaborator

A little confused here, do we need a stripped release or a symbolized release?

@wenyongh wenyongh mentioned this pull request Oct 25, 2023
Closed
wenyongh
wenyongh approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 9a5c777 into bytecodealliance:main Oct 25, 2023
1 check passed
@lum1n0us
Copy link
Collaborator

@cngzhnp please be aware of it.

@cngzhnp
Copy link
Contributor

cngzhnp commented Oct 26, 2023

@lum1n0us Thanks for the warning. However, I do not understand that why we need to revert it. If does not work with macOS which is not possible by the way, only we need to adapt CMakeFiles.txt for this, not to revert it.

Someone needs to see symbols in the static library or shared library should generate binary in DEBUG mode, not release mode in my opinion. Could you please explain it to me more @yamt ?

@yamt
Copy link
Collaborator Author

yamt commented Oct 26, 2023

@lum1n0us Thanks for the warning. However, I do not understand that why we need to revert it. If does not work with macOS which is not possible by the way, only we need to adapt CMakeFiles.txt for this, not to revert it.

Someone needs to see symbols in the static library or shared library should generate binary in DEBUG mode, not release mode in my opinion. Could you please explain it to me more @yamt ?

as far as tested, it produced unlinkable library on ubuntu.
i'm not sure for what platform it has been tested.

@cngzhnp
Copy link
Contributor

cngzhnp commented Oct 26, 2023

Do you have reproduce steps how to test that it was unlinkable library?

@yamt
Copy link
Collaborator Author

yamt commented Oct 26, 2023

Do you have reproduce steps how to test that it was unlinkable library?

have you looked at #2665 ?

victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@yamt
Revert "Strip static and shared libraries of iwasm to reduce the bina…
34e8355 
…ry size (bytecodealliance#2431)" (bytecodealliance#2669)

This reverts commit 7e3a29d:
* it doesn't work for macOS. ("unrecognized option: --strip-all")
* it doesn't work for ubuntu.
  bytecodealliance#2665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yamt @lum1n0us @cngzhnp @wenyongh