Add eabihf ABI support #2745
Add eabihf ABI support #2745
Conversation
core/iwasm/compilation/aot_llvm.c
Outdated
|
|
||
| if (is_baremetal_target(comp_ctx->target_arch, comp_ctx->target_cpu, | ||
| abi)) { | ||
| vendor_sys = "-none-unknown-"; |
There was a problem hiding this comment.
Why need to set vendor sys of thumb to "-none-unknown-"?
There was a problem hiding this comment.
No functional change, just let target triple more close to baremetal platform.
There was a problem hiding this comment.
I guess the vendor sys is changed from "-pc-linux-" to "-none-unknown-", not sure whether it affects functionality. The ABI may be changed?
There was a problem hiding this comment.
I had a test by binary diff with "-pc-linux-" and "-none-unknown-" for a thumb based device, nothing changed in the AOT file.
There was a problem hiding this comment.
It may affect the below "msvc" check, for abi == "msvc" and arch == "thumb", the original vendor_sys is "-pc-windows-", but now it is changed to "-none-unknown-". How about adding the check in the else branch:
if (!strcmp(abi, "msvc")) {
if (!strcmp(arch1, "i386"))
vendor_sys = "-pc-win32-";
else
vendor_sys = "-pc-windows-";
}
else {
if (is_baremetal_target(arch, cpu, abi))
vendor_sys = "-unknown-none-";
else
vendor_sys = "-pc-linux-";
}BTW, it seems that the vendor_sys for bare metal should be "-unknown-none-" but not "-none-unknown-"? Refer to:
https://clang.llvm.org/docs/CrossCompilation.html#target-triple
The vendor needs to be specified only if there’s a relevant change, for instance between PC and Apple. Most of the time it can be omitted (and Unknown) will be assumed, which sets the defaults for the specified architecture. The system name is generally the OS (linux, darwin), but could be special like the bare-metal “none”.
There was a problem hiding this comment.
Does the couple of msvc and thumb is really exists?
Sorry, the triple order is a typo.
There was a problem hiding this comment.
I think the order is ok ? "unknown" for vendor and "none" for system type.
I am not sure, but the document mentions:
The vendor needs to be specified only if there’s a relevant change, for instance between PC and Apple.
Most of the time it can be omitted (and Unknown) will be assumed, which sets the defaults for the specified architecture.
The system name is generally the OS (linux, darwin), but could be special like the bare-metal “none”.
And BTW, does the couple of msvc and thumb is really exists?
msvc + thumb may not exist, but we may add more bare metal target in the future? Such as msvc + aarch64?
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
no1wudi
force-pushed
the
wamrc
branch
2 times, most recently
from
c1fd5b3
to
93dbf68
Compare
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
…codealliance#2745) Set the vendor-sys of bare-metal targets to "-unknown-none-", and currently only add "thumbxxx" to the bare-metal target list. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
No description provided.