Fix printing of external reference addresses in wasm_application.c #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamt
reviewed
Nov 16, 2023
core/iwasm/common/wasm_application.c
Outdated
| @@ -613,7 +613,7 @@ execute_func(WASMModuleInstanceCommon *module_inst, const char *name, | |||
| u.parts[1] = argv1[k + 1]; | |||
| k += 2; | |||
| if (u.val && u.val != (uintptr_t)-1LL) | |||
| os_printf("0x%" PRIxPTR ":ref.extern", (void *)u.val); | |||
| os_printf("%p:ref.extern", (void *)u.val); | |||
There was a problem hiding this comment.
u.val is uintptr_t. why don't you remove the cast instead?
core/iwasm/common/wasm_application.c
Outdated
| @@ -600,7 +600,7 @@ execute_func(WASMModuleInstanceCommon *module_inst, const char *name, | |||
| { | |||
| #if UINTPTR_MAX == UINT32_MAX | |||
| if (argv1[k] != 0 && argv1[k] != (uint32)-1) | |||
| os_printf("0x%" PRIxPTR ":ref.extern", (void *)argv1[k]); | |||
| os_printf("%p:ref.extern", (void *)argv1[k]); | |||
There was a problem hiding this comment.
iirc, how %p converts is implementation-defined.
isn't it a problem for repl?
|
@yamt In fact I'm fine to cast them to uintptr_t but it's from stdint.h, but other type such as uint32 is defined internally, mix usage of them looks a little strange. |
wasm_application.c Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
no1wudi
changed the title
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.